Whether error was set or not, if there's no mapping, that's an error.
authorJoe Wreschnig <joe.wreschnig@gmail.com>
Fri, 15 Mar 2013 22:45:27 +0000 (23:45 +0100)
committerJoe Wreschnig <joe.wreschnig@gmail.com>
Fri, 15 Mar 2013 22:45:27 +0000 (23:45 +0100)
Classes/NJMappingsController.m
Info.plist

index fa851b1..c3209ac 100644 (file)
                                                     mappings:_mappings
                                                        error:&error];
     
                                                     mappings:_mappings
                                                        error:&error];
     
-    if (mapping && !error) {
+    if (mapping) {
         NJMapping *mergeInto = self[mapping.name];
         if ([mergeInto hasConflictWith:mapping]) {
             NSAlert *conflictAlert = [[NSAlert alloc] init];
         NJMapping *mergeInto = self[mapping.name];
         if ([mergeInto hasConflictWith:mapping]) {
             NSAlert *conflictAlert = [[NSAlert alloc] init];
             [self activateMapping:mapping];
             [self mappingsChanged];
         }
             [self activateMapping:mapping];
             [self mappingsChanged];
         }
-    }
-
-    if (error) {
+    } else {
         [window presentError:error
               modalForWindow:window
                     delegate:nil
         [window presentError:error
               modalForWindow:window
                     delegate:nil
index 6dba917..b17e626 100644 (file)
@@ -46,7 +46,7 @@
        <key>CFBundleSignature</key>
        <string>????</string>
        <key>CFBundleVersion</key>
        <key>CFBundleSignature</key>
        <string>????</string>
        <key>CFBundleVersion</key>
-       <string>305</string>
+       <string>306</string>
        <key>LSApplicationCategoryType</key>
        <string>public.app-category.utilities</string>
        <key>NSHumanReadableCopyright</key>
        <key>LSApplicationCategoryType</key>
        <string>public.app-category.utilities</string>
        <key>NSHumanReadableCopyright</key>