From: Joe Wreschnig <joe.wreschnig@gmail.com>
Date: Wed, 17 Mar 2010 04:56:54 +0000 (-0700)
Subject: Fire, relative: I'm certain the reference implementation is wrong.
X-Git-Url: https://git.yukkurigames.com/?p=python-bulletml.git;a=commitdiff_plain;h=2d1ad947cd9ebb183d63b062132fa4df11e8bc61

Fire, relative: I'm certain the reference implementation is wrong.
---

diff --git a/bulletml/impl.py b/bulletml/impl.py
index af3f153..9df26c6 100644
--- a/bulletml/impl.py
+++ b/bulletml/impl.py
@@ -147,8 +147,11 @@ class Action(object):
                     if type == "sequence":
                         speed += self.previous_fire_speed
                     elif type == "relative":
-                        # FIXME(jfw): Reference impl uses prvFireSpeed
-                        # here?  That doesn't seem right at all.
+                        # The reference Noiz implementation uses
+                        # prvFireSpeed here, but the standard is
+                        # pretty clear -- "0 means that the direction
+                        # of this fire and the direction of the bullet
+                        # are the same".
                         speed += self.owner.speed
                 else:
                     speed = 1