X-Git-Url: https://git.yukkurigames.com/?p=python-bulletml.git;a=blobdiff_plain;f=bulletml%2Fimpl.py;h=9a1aa56adda6b9fc69727a34bdd72668f63e16eb;hp=8508896a83a0412789326e50e86b05c3185fff4b;hb=978a7d7372a25f5d2e5d4401151e20fd913bdae0;hpb=72d08f5c5c38da987a496f344e88e51fb956d6a6

diff --git a/bulletml/impl.py b/bulletml/impl.py
index 8508896..9a1aa56 100644
--- a/bulletml/impl.py
+++ b/bulletml/impl.py
@@ -6,15 +6,22 @@ import math
 
 from bulletml import parser
 
-# TODO(jfw): This is very non-Pythonic, it's pretty much just the
-# BulletML reference ActionImpl translated to Python.
-
 PI_2 = math.pi * 2
 
 __all__ = ["Action", "Bullet"]
 
 class Action(object):
-    """Running action implementation."""
+    """Running action implementation.
+
+    To implement new actions,
+
+    - Add a new element/class pair to parser.ActionDef.CONSTRUCTORS.
+      It should support FromXML, __getstate__, and __setstate__.
+    - Subclass impl.Action and override the 'handle' method to handle
+      your custom action type.
+    - Pass the impl.Bullet constructor your Action subclass when
+      creating your root Bullet.
+    """
 
     def __init__(self, owner, parent, actions, params, rank, repeat=1):
         self.actions = actions
@@ -61,9 +68,10 @@ class Action(object):
         self.previous_fire_direction = other.previous_fire_direction
         self.previous_fire_speed = other.previous_fire_speed
 
-    def step(self, owner, rank, created, sin=math.sin, cos=math.cos):
+    def step(self, owner, created, sin=math.sin, cos=math.cos):
         """Advance by one frame."""
         s_params = self.params
+        rank = owner.rank
 
         if self.speed_frames > 0:
             self.speed_frames -= 1
@@ -112,16 +120,17 @@ class Action(object):
 
             if isinstance(action, parser.Repeat):
                 repeat, (actions, params) = action(s_params, rank)
-                child = Action(owner, self, actions, params, rank, repeat)
+                child = self.__class__(
+                    owner, self, actions, params, rank, repeat)
                 owner.replace(self, child)
-                child.step(owner, rank, created, sin, cos)
+                child.step(owner, created, sin, cos)
                 break
 
             elif isinstance(action, (parser.ActionDef, parser.ActionRef)):
                 actions, params = action(s_params, rank)
-                child = Action(owner, self, actions, params, rank)
+                child = self.__class__(owner, self, actions, params, rank)
                 owner.replace(self, child)
-                child.step(owner, rank, created, sin, cos)
+                child.step(owner, created, sin, cos)
                 break
 
             elif isinstance(action, (parser.FireDef, parser.FireRef)):
@@ -165,8 +174,8 @@ class Action(object):
                         x += off_x
                         y += off_y
 
-                bullet = Bullet(
-                    x, y, direction, speed, owner.target, actions, self, rank)
+                bullet = owner.__class__(
+                    x, y, direction, speed, owner.target, actions, rank)
                 created.append(bullet)
 
             elif isinstance(action, parser.ChangeSpeed):
@@ -245,13 +254,19 @@ class Action(object):
 
             elif isinstance(action, parser.Wait):
                 self.wait_frames = action(s_params, rank)
-                if self.wait_frames:
-                    break
+                break
 
             elif isinstance(action, parser.Vanish):
                 owner.vanish()
                 break
 
+            else:
+                self.handle(action, owner, created, sin, cos)
+
+    def handle(self, action, owner, created, sin, cos):
+        """Override in subclasses for new action types."""
+        raise NotImplementedError(action.__class__.__name__)
+
 class Bullet(object):
     """Simple bullet implementation.
 
@@ -269,13 +284,13 @@ class Bullet(object):
     Contructor Arguments:
     x, y, direction, speed, target, rank - same as the attributes
     actions - internal action list
-    parent - parent of actions, None for manually-created bullets
+    Action - custom Action constructor
 
 
     """
 
     def __init__(self, x=0, y=0, direction=0, speed=0, target=None,
-                 actions=(), parent=None, rank=0.5):
+                 actions=(), rank=0.5, Action=Action):
         self.x = self.px = x
         self.y = self.py = y
         self.mx = 0
@@ -290,6 +305,13 @@ class Bullet(object):
         self._actions = [Action(self, None, action, params, rank)
                          for action, params in actions]
 
+    @classmethod
+    def FromDocument(cls, doc, x=0, y=0, direction=0, speed=0, target=None,
+                     params=(), rank=0.5, Action=Action):
+        """Construct a new Bullet from a loaded BulletML document."""
+        actions = [a(params, rank) for a in doc.actions]
+        return cls(x, y, direction, speed, target, actions, rank, Action)
+
     def __repr__(self):
         return ("%s(%r, %r, accel=%r, direction=%r, speed=%r, "
                 "actions=%r, target=%r, vanished=%r)") % (
@@ -299,11 +321,17 @@ class Bullet(object):
 
     @property
     def aim(self):
-        """Angle to the target, in radians."""
-        if self.target is None:
-            return self.direction
+        """Angle to the target, in radians.
+
+        If the target does not exist or cannot be found, return 0.
+        """
+        try:
+            target_x = self.target.x
+            target_y = self.target.y
+        except AttributeError:
+            return 0
         else:
-            return math.atan2(self.target.x - self.x, self.y - self.target.y)
+            return math.atan2(target_x - self.x, self.y - target_y)
 
     @property
     def finished(self):
@@ -353,7 +381,7 @@ class Bullet(object):
         created = []
 
         for action in self._actions:
-            action.step(self, self.rank, created, sin, cos)
+            action.step(self, created, sin, cos)
 
         self.px = self.x
         self.py = self.y