From 5c56b988cdf5079dd5f3f256012e0d0a384f96f7 Mon Sep 17 00:00:00 2001 From: Joe Wreschnig Date: Fri, 15 Mar 2013 23:45:27 +0100 Subject: [PATCH] Whether error was set or not, if there's no mapping, that's an error. --- Classes/NJMappingsController.m | 6 ++---- Info.plist | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Classes/NJMappingsController.m b/Classes/NJMappingsController.m index fa851b1..c3209ac 100644 --- a/Classes/NJMappingsController.m +++ b/Classes/NJMappingsController.m @@ -231,7 +231,7 @@ mappings:_mappings error:&error]; - if (mapping && !error) { + if (mapping) { NJMapping *mergeInto = self[mapping.name]; if ([mergeInto hasConflictWith:mapping]) { NSAlert *conflictAlert = [[NSAlert alloc] init]; @@ -256,9 +256,7 @@ [self activateMapping:mapping]; [self mappingsChanged]; } - } - - if (error) { + } else { [window presentError:error modalForWindow:window delegate:nil diff --git a/Info.plist b/Info.plist index 6dba917..b17e626 100644 --- a/Info.plist +++ b/Info.plist @@ -46,7 +46,7 @@ CFBundleSignature ???? CFBundleVersion - 305 + 306 LSApplicationCategoryType public.app-category.utilities NSHumanReadableCopyright -- 2.20.1