From: Joe Wreschnig <joe.wreschnig@gmail.com>
Date: Wed, 17 Mar 2010 04:51:39 +0000 (-0700)
Subject: Bullet.finished: Check vanished before checking actions, it's faster.
X-Git-Url: https://git.yukkurigames.com/?a=commitdiff_plain;h=5f93dc227463ac9a34bfe4d06b67b7d07bfb12cc;p=python-bulletml.git

Bullet.finished: Check vanished before checking actions, it's faster.
---

diff --git a/bulletml/impl.py b/bulletml/impl.py
index cc693e1..af3f153 100644
--- a/bulletml/impl.py
+++ b/bulletml/impl.py
@@ -264,10 +264,12 @@ class Bullet(object):
     @property
     def finished(self):
         """Check if this bullet is finished running."""
+        if not self.vanished:
+            return False
         for action in self.actions:
             if not action.finished:
                 return False
-        return self.vanished
+        return True
 
     def vanish(self):
         """Vanish this bullet and stop all actions."""