More efficient way to get LTR diffLerp editing.

diff --git a/string-lerp.js b/string-lerp.js
index 2096a07ab6892d47499b7ae705141a36040ff40d..3a304886374373c3471aaf530a92f2615ea5544d 100644 (file)
--- a/string-lerp.js
+++ b/string-lerp.js
@@ -79,10 +79,6 @@
         return s;
     }
 
-    function reverse (s) {
-        return s.split("").reverse().join("");
-    }
-
     function diffLerp(a, b, p) {
         /** Interpolate between two strings based on edit distance
 
@@ -92,11 +88,14 @@
             compute the edits. It is not recommended for strings
             longer than a few hundred characters.
          */
-        a = reverse(a);
-        b = reverse(b);
-        var edits = diff(a, b);
-        var partial = edits.slice(0, Math.round(p * edits.length));
-        return reverse(patch(partial, a));
+
+        // The edit path works from the string end, forwards, because
+        // that's how Levenshtein edits work. To match LTR reading
+        // direction (and the behavior of fastLerp), swap the strings
+        // and invert the parameter when editing.
+        var edits = diff(b, a);
+        var partial = edits.slice(0, Math.round((1 - p) * edits.length));
+        return patch(partial, b);
     }
 
     var NUMBERS = /(-?\d+(?:\.\d+)?)/g;

diff --git a/tests/string-lerp.js b/tests/string-lerp.js
index 8ef0bc758681b83db1137f5069846744c78d7458..921e199d59b7d0b8c2a7f9cb4757559e6fc3583b 100644 (file)
--- a/tests/string-lerp.js
+++ b/tests/string-lerp.js
@@ -73,9 +73,11 @@ JS.Test.describe('diff lerp', function () { with (this) {
     }});
 
     it("edits strings", function () { with (this) {
+        assertEqual(A, lerp(A, B, 0.01));
         assertEqual("I do not like treen eggs and ham?", lerp(A, B, 0.3));
-        assertEqual("I do not like them, Sggs and ham?", lerp(A, B, 0.5));
+        assertEqual("I do not like them, eggs and ham?", lerp(A, B, 0.5));
         assertEqual("I do not like them, Sam-Iham?", lerp(A, B, 0.9));
+        assertEqual(B, lerp(A, B, 0.99));
     }});
 }});