Action: Fix probable bug in direction handling when there's only one frame left.
authorJoe Wreschnig <joe.wreschnig@gmail.com>
Wed, 17 Mar 2010 07:48:32 +0000 (00:48 -0700)
committerJoe Wreschnig <joe.wreschnig@gmail.com>
Wed, 17 Mar 2010 07:48:32 +0000 (00:48 -0700)
bulletml/impl.py

index a056d6c4390642ed78e0a3cb013eccdd5c92fb1d..fcb3aab34ea99da4e76f2c6fdee77b1fd7ded9ce 100644 (file)
@@ -73,10 +73,13 @@ class Action(object):
             self.owner.speed += self.speed
 
         if self.direction_frames > 0:
+            # The Noiz implementation was a little weird here, I think
+            # there was a bug in it that prevented it from working if
+            # the frame count was 1. I'm still not sure what the aim
+            # check is supposed to do, exactly.
             self.direction_frames -= 1
-            if self.direction_frames <= 0:
-                if self.aiming:
-                    self.owner.direction += self.owner.aim
+            if self.aiming and self.direction_frames <= 0:
+                self.owner.direction += self.owner.aim
             else:
                 self.owner.direction += self.direction